Modified Git Script To Persist Old Records#199
Open
saiteja13427 wants to merge 1 commit intoashutosh1919:masterfrom
Open
Modified Git Script To Persist Old Records#199saiteja13427 wants to merge 1 commit intoashutosh1919:masterfrom
saiteja13427 wants to merge 1 commit intoashutosh1919:masterfrom
Conversation
Owner
|
@saiteja13427 merging this one will take time since it is not related to UI. |
Collaborator
Author
|
@ashutosh1919 Sure, I tried covering all the edge cases i could think of, do test it locally with your profile and let me know if you see any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified git script to persist the old records and add on top of it. Solves issue #159
Changes
Reason for changes
As we get only 100 records on every fetch to the API, there is a chance that for people with more than 100 PRs or 100 issues, the previous data will disappear.
To tackle this, we will now be appending any new data to the previous data.
Note: I did not format the JSON files, probably was done by husky pre-commit. Due to that, you will see huge change size. But the only change in those json files is clear: true.