Skip to content

feat: Add granular NumberMode for parsing numbers#29

Open
arran4 wants to merge 1 commit into
mainfrom
feat/number-mode-11731985683681448261
Open

feat: Add granular NumberMode for parsing numbers#29
arran4 wants to merge 1 commit into
mainfrom
feat/number-mode-11731985683681448261

Conversation

@arran4
Copy link
Copy Markdown
Owner

@arran4 arran4 commented May 31, 2026

Adds a NumberMode enum (NumberModeNone, NumberModeSplitAlways, NumberModeMergeRecursive, NumberModeTreatAsLowercase) to the parser and partitioner configurations to provide granular control over digit parsing boundaries. Updates CamelCasePartitioner to handle the different NumberMode strategies. Preserves the legacy WithNumberSplitting API by wrapping the new NumberMode logic. Includes tests for the new functionalities.


PR created automatically by Jules for task 11731985683681448261 started by @arran4

Replaces the boolean `NumberSplitting` flag with a `NumberMode` enum, allowing for finer control over digit boundaries. Introduces `MergeRecursive` (which merges digits with words but splits before uppercase letters) and `TreatAsLowercase` (which treats digits identically to lowercase letters). The existing `WithNumberSplitting` option is retained for backward compatibility and mapped to the new modes. Fixes #23.

Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant