Open
Conversation
Collaborator
|
Thanks @AlexanderCaichen for the great work. It will be nice to allow the preprocessing algorithm knows whether the data is already normalized or not automatically. Is this not something different? |
Contributor
Author
|
@Xiaojieqiu Because there are so many ways of normalizing data I thought it will be difficult to have a single function automatically detect whether some data is normalized. While I can add a check somewhere to see if some data is normalized by Dynamo, it is possible that the data to be preprocessed is already pre-normalized outside of Dynamo. My changes simply gives the User the option of canceling normalization in Dynamo in case they pre-normalized it instead of automatically detecting normalization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new input variable for Preprocessor object to skip normalization in case data-to-be-preprocessed is already normalized.