This repository was archived by the owner on Dec 5, 2025. It is now read-only.
changing to updated service Command NetworkManager#318
Open
jatinkartik wants to merge 1 commit intoarismelachroinos:masterfrom
Open
changing to updated service Command NetworkManager#318jatinkartik wants to merge 1 commit intoarismelachroinos:masterfrom
jatinkartik wants to merge 1 commit intoarismelachroinos:masterfrom
Conversation
haydenkz
approved these changes
Dec 11, 2021
|
This contribution resolves a critical compatibility issue by replacing |
avidzcheetah
reviewed
Jan 2, 2025
avidzcheetah
left a comment
There was a problem hiding this comment.
The code diff shows a minor change in a script where the service network-manager has been replaced with NetworkManager. Here is a summary and review of the change:
Summary
The change updates the command to start the network manager service:
- Old Command:
service network-manager start - New Command:
service NetworkManager start
Review
- Correct Naming: The change corrects the service name from
network-managertoNetworkManager. This is likely because the correct service name isNetworkManager, which is case-sensitive. - Functionality: This update ensures that the script correctly starts the NetworkManager service, which is crucial for network management tasks on systems using NetworkManager.
- Error Handling: The existing error handling and success messages are preserved, ensuring that any issues starting the service will still be reported properly.
Overall, this is a necessary and correct change to ensure the script functions as intended on systems where the service name is case-sensitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when I am disabling monitor mode using lscript its disables monitor mode but doesn't start network service I have to manually start it. then I have tested this script on multiple systems. but the result is the same.
After changing network-manager to NetworkManager. Now it's working fine.
network-manager is the symbolic link of NetworkManager. but it's not working on some virtual machine.
so take a look at my contribution. if you found this helpful merge it.
currently, I am testing this script if I found any issues. I will update it