feat: use mimalloc as the default allocator#16639
Draft
DaniPopes wants to merge 9 commits intoargotorg:developfrom
Draft
feat: use mimalloc as the default allocator#16639DaniPopes wants to merge 9 commits intoargotorg:developfrom
DaniPopes wants to merge 9 commits intoargotorg:developfrom
Conversation
Fetch mimalloc v2.2.2 via FetchContent and link it statically to all executables with MI_OVERRIDE=ON so that malloc/free are replaced globally without any source changes. Disabled for Emscripten builds. Can be turned off with -DUSE_MIMALLOC=OFF.
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
FetchContent_MakeAvailable requires CMake 3.14+. Use the manual FetchContent_GetProperties/FetchContent_Populate pattern instead.
Match the pattern used by fmtlib, nlohmann-json, and range-v3.
Required by mimalloc v3.3.1.
The emscripten CI image ships CMake 3.16. Instead of bumping the project-wide minimum, guard mimalloc behind a version check and expose MIMALLOC_ENABLED for downstream CMakeLists.
MI_OVERRIDE causes SIGABRT on macOS since Apple's allocator cannot be fully replaced.
Static linking on macOS requires -force_load to prevent the linker from stripping mimalloc's constructor that sets up the malloc zone override.
mimalloc v3 requires MSVC >= VS2022 (Windows CI uses VS2019), and macOS requires special linker flags for malloc zone constructors. Restrict to Linux where the perf benefit matters most.
- Use CMAKE_SYSTEM_NAME=Linux instead of UNIX (excludes BSDs) - Disable when IGNORE_VENDORED_DEPENDENCIES is set - Disable for sanitizer builds (SANITIZE) - Fix docs: submodule not FetchContent, document all conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use mimalloc v3.3.1 as the default allocator. Linked statically with
MI_OVERRIDE=ONso allmalloc/freecalls are replaced globally — no source changes needed. Disabled for Emscripten builds. Disable with-DUSE_MIMALLOC=OFF.Benchmarks