Open
Conversation
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
react-form compatibility changes Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
- Add local state for input value to fix typing lag in React 19 (previously read directly from props) - Sync local state from props.value for external updates - Fix menu positioning to use viewport-relative coords (position:fixed) instead of document coords - Remove scroll offset from menu top/left calculations - Add overflowY:auto to menu for scrollable long lists - Manually merge menuRef with downshift's ref to avoid ref callback conflicts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades Repo to React-19
Notable changes
There's a lot of changes in this PR, some of them are just
react-form Compatibility Layer (src/components/form/compat.tsx) — New file
The react-form package (which used class-based internals incompatible with React 19) was removed and replaced with a custom hooks-based implementation that preserves the same public API surface.
Implements the following:
Autocomplete Re-implementation (src/components/autocomplete/autocomplete.tsx)
Replaced the deprecated react-autocomplete library with a custom implementation built on downshift's useCombobox hook:
Exports (src/components/index.ts)
All compatibility layer types and components are re-exported from the package's main entry point, allowing argo-cd to import from argo-ui without changes.
Enzyme Sunset
Enzyme is no longer supported for React 19, it needed to be removed.
Other Changes