fix(controller): prevent canary scale-up after abort with dynamic stable scaling - #5018
Open
AruneshDwivedi wants to merge 1 commit into
Open
AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
…ble scaling When aborting with dynamic stable scaling, the canary replica count is now set to 0 instead of using max(trafficWeightReplicaCount, canaryCount). The previous logic could scale the canary back up if weights.Canary.Weight was stale, causing the canary RS to grow when spec.replicas increased.
|
Contributor
Published E2E Test Results4 files 8 suites 0s ⏱️ For more details on these failures, see this check. Results for commit acecb1f. |
Contributor
Published Unit Test Results 1 files 132 suites 1m 2s ⏱️ For more details on these failures, see this check. Results for commit acecb1f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When aborting with dynamic stable scaling, the canary replica count is now set to 0 instead of using max(trafficWeightReplicaCount, canaryCount). The previous logic could scale the canary back up if weights.Canary.Weight was stale, causing the canary RS to grow when spec.replicas increased.
Changes
Fixes #4973