Skip to content

feat[ibmsm]: Add support for service_credentials secret type#629

Open
jgawor wants to merge 7 commits intoargoproj-labs:mainfrom
jgawor:ibm_secret_manager_service_creds
Open

feat[ibmsm]: Add support for service_credentials secret type#629
jgawor wants to merge 7 commits intoargoproj-labs:mainfrom
jgawor:ibm_secret_manager_service_creds

Conversation

@jgawor
Copy link
Copy Markdown
Contributor

@jgawor jgawor commented Apr 19, 2024

Description

Add support for service_credentials secret type.

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.21 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

jgawor added 4 commits April 18, 2024 12:10
@jgawor
service_credential secret type
1d33dd3 
Signed-off-by: Jarek Gawor <jgawor@gmail.com>
@jgawor
add tests
c8d7c36 
Signed-off-by: Jarek Gawor <jgawor@gmail.com>
@jgawor
handle in consistent way
ae73502 
Signed-off-by: Jarek Gawor <jgawor@gmail.com>
@jgawor
go mod tidy
0f41f6f 
Signed-off-by: Jarek Gawor <jgawor@gmail.com>
@jgawor jgawor requested review from jkayani and werne2j as code owners April 19, 2024 03:57
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.79%. Comparing base (42a43f0) to head (b5b161b).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
- Coverage   72.16%   71.79%   -0.38%     
==========================================
  Files          26       29       +3     
  Lines        1994     2627     +633     
==========================================
+ Hits         1439     1886     +447     
- Misses        458      589     +131     
- Partials       97      152      +55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jkayani
jkayani approved these changes May 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jkayani jkayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's adding support for another secret type and it looks like it works like the others do, so no need to add to docs.

Thanks!

@jgawor
Copy link
Copy Markdown
Contributor Author

jgawor commented May 27, 2024

@werne2j could you please take a look at this PR? thanks.

werne2j
werne2j approved these changes Jun 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just rebase the branch and then we can merge.

@jgawor
resolve merge conflicts
86fdaa9 
Signed-off-by: Jarek Gawor <jgawor@gmail.com>
@jgawor jgawor force-pushed the ibm_secret_manager_service_creds branch from fa2dad5 to 86fdaa9 Compare June 14, 2024 22:25
@jgawor
Copy link
Copy Markdown
Contributor Author

jgawor commented Jun 15, 2024

@werne2j updated now

@jgawor
Copy link
Copy Markdown
Contributor Author

jgawor commented Jun 27, 2024

@werne2j one more ping :)

@jgawor
Copy link
Copy Markdown
Contributor Author

jgawor commented Jul 19, 2024

@werne2j one more ping

@jgawor
Copy link
Copy Markdown
Contributor Author

jgawor commented Aug 4, 2024

@werne2j and one more ping.

@jgawor
Copy link
Copy Markdown
Contributor Author

jgawor commented Aug 6, 2024

@jkayani maybe you can merge?

@werne2j
Copy link
Copy Markdown
Member

werne2j commented Sep 29, 2024 •
edited
Loading

@jgawor looks like there are conflicts. Once resolved i will merge this in.

@jgawor
Copy link
Copy Markdown
Contributor Author

jgawor commented Nov 27, 2024

@werne2j I just updated the PR.

@jgawor
Copy link
Copy Markdown
Contributor Author

jgawor commented Dec 3, 2024

@werne2j one more ping

1 similar comment
@jgawor
Copy link
Copy Markdown
Contributor Author

jgawor commented Dec 11, 2024

@werne2j one more ping

@jgawor
Copy link
Copy Markdown
Contributor Author

jgawor commented Dec 20, 2024

@werne2j @jkayani one more ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@werne2j werne2j werne2j approved these changes

@jkayani jkayani jkayani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgawor @codecov-commenter @werne2j @jkayani