feat: Update apiVersion argoproj.io/v1alpha1 to v1beta1 for ArgoCD in docs and tests#1827
Open
olivergondza wants to merge 2 commits intoargoproj-labs:masterfrom
Open
feat: Update apiVersion argoproj.io/v1alpha1 to v1beta1 for ArgoCD in docs and tests#1827olivergondza wants to merge 2 commits intoargoproj-labs:masterfrom
olivergondza wants to merge 2 commits intoargoproj-labs:masterfrom
Conversation
jgwest
requested changes
Aug 19, 2025
Member
jgwest
left a comment
There was a problem hiding this comment.
For the kuttl tests, IMHO we can leave them as is and remove those changes from this PR. Why?
- The kuttl tests will likely be entirely removed shortly, anyways.
- The kuttl tests are no longer run as part of PRs, so this PR may unintentionally break them and we would not know. (Unless, for example, you have personally run those kuttl tests yourself from your own machine)
Collaborator
Author
Yeah, makes sense since we want to throw them away. For my complete kuttl ignorance, it will that be all the references in |
8fbaf3e to
24d8230
Compare
… docs and tests Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind chore
What does this PR do / why we need it:
The examples in the docs are outdated
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
None
How to test changes / Special notes to the reviewer: