-
Notifications
You must be signed in to change notification settings - Fork 2
Add figure issue template #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Adding current graduate students as reviewers because I would like their feedback on the included list. |
ZoeRichter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I approve - I suggested a few minor changes, but nothing critical. The link to the viridis colormap page is for future us.
LukeSeifert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intent for people to create an issue/sub-issue for each figure they plan to generate? If so, I wonder if maybe some of these criteria should be delegated to the website and just have a single checkbox indicating that the "Figure criteria on the website has been fulfilled".
Co-authored-by: Zoe <[email protected]>
Co-authored-by: Zoe <[email protected]>
Co-authored-by: LukeSeifert <[email protected]>
I would agree (that or we put this checklist directly into a review template for the PR), but we are waiting on merging from a different PR. The plan for now was to add this in and move the list later. |
Summary of changes
Adds an issue template for creating figures.
Includes a short checklist of items for use by members.
This checklist would ideally be added to the ARFC website, not this issue, but I was waiting on a more-official list from Matt's PR.
Types of changes
Associated Issues and PRs
Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.