[4.x] Add tenant parameter BEFORE existing prefixes by default#1393
Merged
[4.x] Add tenant parameter BEFORE existing prefixes by default#1393
Conversation
…arameterBeforePrefix() to allow customizing this
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## august #1393 +/- ##
============================================
+ Coverage 86.34% 86.37% +0.02%
- Complexity 1111 1113 +2
============================================
Files 178 178
Lines 3252 3259 +7
============================================
+ Hits 2808 2815 +7
Misses 444 444 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Related history https://github.com/tenancy-for-laravel/v4/pull/49 |
Member
|
And slightly less related 0f7cd2e |
stancl
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, cloning a route would add the tenant parameter after all existing route prefixes. Now, the clone action has the
$tenantParameterBeforePrefixproperty, which istrueby default, meaning the tenant parameter gets added before the existing prefixes. This can be customized by calling$cloneAction->tenantParameterBeforePrefix(false)-- that way, the original behavior would be preserved.For example, this solves the problem with Filament, where the cloned routes would look like
/filament/{tenant}/something, which isn't ideal for many reasons (main reason is that the routes would be completely broken and the admin panel routes wouldn't work correctly. The other reason is that for consistency, tenant routes should have the{tenant}parameter before the existing prefixes (but as I mentioned, this is configurable).