feat(helm): add native private registry credentials for scan jobs#2887
Open
rzala wants to merge 1 commit intoaquasecurity:mainfrom
Open
feat(helm): add native private registry credentials for scan jobs#2887rzala wants to merge 1 commit intoaquasecurity:mainfrom
rzala wants to merge 1 commit intoaquasecurity:mainfrom
Conversation
Add trivy.registryCredentials to automatically create a dockerconfigjson Secret and inject it into scan jobs via the operator ConfigMap's scanJobCustomVolumes/scanJobCustomVolumesMount. Previously, users had to manually create the docker config secret and hand-craft the JSON for scanJobCustomVolumes, which was error-prone. This feature automates the common case while merging with any existing user-specified custom volumes. The credential secret is mounted at /root/.docker/config.json (standard Docker config location) so Trivy can pull images from private registries without additional configuration. New values: - trivy.registryCredentials.create: enable secret creation - trivy.registryCredentials.secretName: secret name - trivy.registryCredentials.registry: registry URL - trivy.registryCredentials.username: registry username - trivy.registryCredentials.password: registry password
rzala
force-pushed
the
feature/helm-registry-credentials
branch
from
8c270d3 to
fa32386
Compare
rzala
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add trivy.registryCredentials to automatically create a dockerconfigjson Secret and inject it into scan jobs via the operator ConfigMap's scanJobCustomVolumes/scanJobCustomVolumesMount.
Previously, users had to manually create the docker config secret and hand-craft the JSON for scanJobCustomVolumes, which was error-prone. This feature automates the common case while merging with any existing user-specified custom volumes.
The credential secret is mounted at /root/.docker/config.json (standard Docker config location) so Trivy can pull images from private registries without additional configuration.
New values:
Checklist