Generate RuboCop-clean Ruby SDK files - #1840
Merged
Merged
Conversation
ChiragAgg5k
marked this pull request as ready for review
August 25, 2026 04:04
Contributor
Greptile SummaryThe PR updates Ruby SDK templates to emit RuboCop Layout-clean code directly and adds generated RuboCop configuration plus CI validation.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "feat: generate RuboCop-clean Ruby SDK fi..." | Re-trigger Greptile |
Emit Layout-clean Ruby from Twig templates so a fresh generation already matches RuboCop 1.90.0 (4-space indent, Layout cops only). Ship .rubocop.yml with the SDK and fail CI on formatter regressions. Co-authored-by: Chirag Aggarwal <chiragaggarwal5k@gmail.com>
cursor
Bot
force-pushed
the
cursor/ruby-formatter-clean-9f05
branch
from
August 25, 2026 05:41
d6ea4a9 to
aaaae29
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.rubocop.ymlwith Layout cops only, 4-space indent matching sdk-for-ruby house style, and a 200-character line limitPart of #1813.
Ruby has no inherited/child SDK targets. REST/GraphQL/skills/editor plugins are out of scope.
CI note (web client on d6ea4a9)
Validation job web (client) failed in ~20s on
php example.php web client, before any npm step:This PR does not change Web templates. The same job on later
main(#1842) was green. Cause:getSSLPage()returned non-empty invalid JSON from the live specs fetch (Parser.php:57json_decode(..., JSON_THROW_ON_ERROR)). Rebased ontomain(328cc07fa, #1842) and re-verified locally. No retry/sleep/continue-on-erroradded.Greptile review on d6ea4a9 was 5/5 with no line comments.
Test plan
Ruby (#1813):
rm -rf examples/ruby && php example.php ruby server— pass (1/1 after rebase)(cd examples/ruby && rubocop)— 405 files inspected, no offenses (1/1)rm -rf examples/ruby && php example.php ruby client && (cd examples/ruby && rubocop)— 120 files, no offenses (1/1, pre-rebase)composer lint-twig— 0 errorsvendor/bin/phpcs src/SDK/Language/Ruby.php— passWeb (the red CI job, after rebase):
open-api3-1.9.x-client.jsonandjson_decode— valid JSON (1/1)rm -rf examples/web && php example.php web client— pass (1/1)(cd examples/web && npm ci && npm audit && npm run format:check && npm run lint && npm run analyse && npm run build)— pass (1/1)Console generation (
php example.php ruby console) still hits a pre-existingLint/Syntaxfailure inconsole_variables.rb: several_APP_*schema names collapse to the same snake_case keyword. That collision exists onmainand is not introduced here.