fix: prevent browser password save prompt and fix action menu clipping on env variables#3096
Merged
Conversation
…g on env variables - Pass autocomplete="new-password" on env variable value fields so browsers don't treat them as login forms and trigger the save-password popup - Add portal prop to the variables action menu Popover so it renders outside the table container and is no longer clipped when opened from the last row
Contributor
Greptile SummaryFixes two independent UI bugs in the environment variables feature: a browser password-save prompt triggered by the key+value form layout, and an action-menu Popover that was clipped when opened from the last table row.
Confidence Score: 5/5Safe to merge — changes are narrowly scoped attribute additions that follow established patterns already present throughout the codebase. Both fixes are small, targeted, and verified against the existing usage patterns: No files require special attention. Important Files Changed
Reviews (5): Last reviewed commit: "format" | Re-trigger Greptile |
ChiragAgg5k
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<InputPassword>which renders astype="password". Browsers were matching the Key + Value fields as a username/password login form and showing "Save password?". Fixed by passingautocomplete="new-password"on the value field in both create and update variable modals, and extendingInputPasswordto accept a stringautocompletevalue (previously only accepted boolean)....action menuPopoverwas usingposition: absoluteinside the table container, causing it to be clipped when opened from the last row. Addedportalprop so the popover renders indocument.bodyinstead — the component already usesflip()from floating-ui so it will auto-position correctly.Files changed
src/lib/elements/forms/inputPassword.svelte— extendedautocompleteprop to acceptboolean | stringsrc/routes/(console)/project-[region]-[project]/createVariableModal.svelte— passautocomplete="new-password"on value fieldsrc/routes/(console)/project-[region]-[project]/updateVariablesModal.svelte— passautocomplete="new-password"on value fieldsrc/routes/(console)/project-[region]-[project]/updateVariables.svelte— addportalto action menu PopoverTest plan
...action menu on the last variable in the list — confirm full menu (Update / Secret / Promote / Delete) is visible without clipping