Skip to content

fix: prevent browser password save prompt and fix action menu clipping on env variables#3096

Merged
HarshMN2345 merged 5 commits into
mainfrom
fix-env-variable-ui-issues
Jun 29, 2026
Merged

fix: prevent browser password save prompt and fix action menu clipping on env variables#3096
HarshMN2345 merged 5 commits into
mainfrom
fix-env-variable-ui-issues

Conversation

@HarshMN2345

Copy link
Copy Markdown
Member

Summary

  • Password save popup: Environment variable value fields use <InputPassword> which renders as type="password". Browsers were matching the Key + Value fields as a username/password login form and showing "Save password?". Fixed by passing autocomplete="new-password" on the value field in both create and update variable modals, and extending InputPassword to accept a string autocomplete value (previously only accepted boolean).
  • Action menu truncation: The ... action menu Popover was using position: absolute inside the table container, causing it to be clipped when opened from the last row. Added portal prop so the popover renders in document.body instead — the component already uses flip() from floating-ui so it will auto-position correctly.

Files changed

  • src/lib/elements/forms/inputPassword.svelte — extended autocomplete prop to accept boolean | string
  • src/routes/(console)/project-[region]-[project]/createVariableModal.svelte — pass autocomplete="new-password" on value field
  • src/routes/(console)/project-[region]-[project]/updateVariablesModal.svelte — pass autocomplete="new-password" on value field
  • src/routes/(console)/project-[region]-[project]/updateVariables.svelte — add portal to action menu Popover

Test plan

  • Create environment variables — confirm no "Save password?" browser dialog appears
  • Edit an environment variable — confirm no browser password save prompt
  • Open the ... action menu on the last variable in the list — confirm full menu (Update / Secret / Promote / Delete) is visible without clipping

…g on env variables

- Pass autocomplete="new-password" on env variable value fields so browsers
  don't treat them as login forms and trigger the save-password popup
- Add portal prop to the variables action menu Popover so it renders outside
  the table container and is no longer clipped when opened from the last row
@greptile-apps

greptile-apps Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Fixes two independent UI bugs in the environment variables feature: a browser password-save prompt triggered by the key+value form layout, and an action-menu Popover that was clipped when opened from the last table row.

  • autocomplete="new-password" is added to the InputPassword value field in both createVariableModal and updateVariablesModal, which is the standard HTML5 signal to browsers not to treat the form as a login form. InputPassword is extended to accept a string autocomplete value alongside its existing boolean support.
  • portal is added to the action-menu Popover in updateVariables.svelte, causing it to render in document.body and avoid overflow clipping; this is consistent with how other Popover and Tooltip components in the codebase already use the portal prop.

Confidence Score: 5/5

Safe to merge — changes are narrowly scoped attribute additions that follow established patterns already present throughout the codebase.

Both fixes are small, targeted, and verified against the existing usage patterns: portal on Popover is used identically in permissions/row.svelte and dualTimeView.svelte, and autocomplete="new-password" is the correct HTML5 token for this use case. No logic or data-flow changes are involved.

No files require special attention.

Important Files Changed

Filename Overview
src/lib/elements/forms/inputPassword.svelte Extends autocomplete prop to accept `boolean
src/routes/(console)/project-[region]-[project]/createVariableModal.svelte Adds autocomplete="new-password" to the InputPassword value field to prevent the browser from triggering a password-save prompt.
src/routes/(console)/project-[region]-[project]/updateVariablesModal.svelte Adds autocomplete="new-password" to the InputPassword value field, matching the fix applied to createVariableModal.svelte.
src/routes/(console)/project-[region]-[project]/updateVariables.svelte Adds portal to the action-menu Popover so it renders in document.body, preventing clipping when opened from the last row; follows the same established pattern used in other Popovers in the codebase.

Reviews (5): Last reviewed commit: "format" | Re-trigger Greptile

Comment thread src/lib/elements/forms/inputPassword.svelte Outdated
@HarshMN2345 HarshMN2345 merged commit b6f1e6b into main Jun 29, 2026
3 of 4 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-env-variable-ui-issues branch June 29, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants