CI improvements#26
Open
rnro wants to merge 7 commits into
Open
Conversation
* Override `macos_build_command` to also `xcodebuild` the package for Mac Catalyst, iOS, watchOS, tvOS, and visionOS in addition to the existing macOS `swift test`, matching the platforms swift-nio's `macos_tests.yml` covers. * Run every step regardless of earlier failures so a single platform break does not hide regressions on the others; the trailing `exit` fails the job if any step failed. * Wrap the command in `bash -c '...' bash` so the reusable workflow's appended `swift_flags` flow through `$@` to `xcrun swift test`.
* Flip `enable_linux_static_sdk_build` to `true` so PRs also build the package with the Static Linux Swift SDK across the workflow's default Swift versions.
* Override `linux_build_command` to build with three trait combinations -- default, additive traits on (`DatapathLogging`/`QlogOutput`/`SignpostOutput`), and reductive traits on (`DisableDebugLogging`/`DisableErrorLogging`) -- before running the test suite in both debug and release. * `set -e` stops the chain on the first failure; the trailing `bash` forwards the reusable workflow's `swift_flags` (and `swift_nightly_flags`) to every step via `"$@"` so each build gets the same toolchain flags.
* Configure Dependabot to track GitHub Actions updates weekly and group `swiftlang/github-workflows/*` bumps so version pins like the recent `0.0.11` move arrive as a single PR rather than one per workflow file.
* Pass `--quiet` to every `swift build` and `swift test` in the Linux trait-build chain and to `xcrun swift test` in the macOS job so logs surface compiler diagnostics and test failures rather than routine progress output. * Echo a `=== <step>: PASSED ===` line after every Linux step and a trailing `=== Summary: all builds and tests passed ===`. With `set -e` retained, a missing PASSED line is the implicit failed-step marker for unfamiliar readers.
Contributor
Author
|
Static SDK failures are expected due to a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xcrun swift test. Every step runs regardless of earlier failures and a final summary table reports per-platformPASSED/FAILED.DatapathLogging/QlogOutput/SignpostOutput)DisableDebugLogging/DisableErrorLogging).swiftlang/github-workflowspin from0.0.9to0.0.11to pick up updated static-SDK defaults (the0.0.9default matrix installs Swift 6.2 toolchains, which can't satisfy our 6.3swift-tools-version).swiftlang/github-workflows/*bumps so future pin updates arrive as a single PR rather than one per workflow file.--quietto everyswift build/swift testand toxcrun swift test=== <step>: PASSED ===markers per step (plus a column-aligned summary on macOS and an "all builds and tests passed" footer on Linux)