QUIC: Cap the number of tracked ACK blocks#24
Merged
Conversation
- Add `maxAckBlocks` limit (256) to bound per-space ACK block growth - Drop the oldest block while building ACKs once the cap is exceeded, preventing unbounded memory and ACK frame size from fragmented or reordered traffic - Document the rationale behind `pingThreshold`, `maxAckBlocks`, and `immediateAcks` - Add tests covering the cap, boundary, and stability behavior
kkuk24
approved these changes
Jun 17, 2026
agnosticdev
approved these changes
Jun 17, 2026
tfpauly
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxAckBlockslimit (256) to bound per-space ACK block growthpreventing unbounded memory and ACK frame size from fragmented or
reordered traffic
pingThreshold,maxAckBlocks, andimmediateAcks