Disable Netlink to unblock swift-nio-quic builds#23
Conversation
| init?(_ bytes: [UInt8]) { | ||
| if bytes.count >= NetlinkAddress.layoutSize { | ||
| #if os(Linux) | ||
| #if os(Linux) && NETLINK_ENABLED |
There was a problem hiding this comment.
Isn't this and other changes actually widening the enablement of this code path rather than disabling it?
There was a problem hiding this comment.
The thought here was that enabling this flag would allow us to selectively re-enable this when adding it back in the future.
There was a problem hiding this comment.
Sorry, for some reason I read the diff in reverse🙃. Makes sense.
|
What is the path to enable this as an adopter, i.e., does it need a trait? |
As an adopter if you wanted to adopt or work on this you would need add in |
rnro
left a comment
rnro
left a comment
There was a problem hiding this comment.
I am not sure about some of the details here but I think this serves the main purpose of unblocking adopters and we can iterate
4 participants
This PR disables the Netlink functionality until we devise a strategy to support this functionality long term on all Linux variants. This will unblock the swift-nio-quic builds and hopefully address this issue: #19