Skip to content

Fix QUICTransfer#16

Merged
agnosticdev merged 3 commits into
mainfrom
agnosticDev/FixQUICTransfer
Jun 16, 2026
Merged

Fix QUICTransfer#16
agnosticdev merged 3 commits into
mainfrom
agnosticDev/FixQUICTransfer

Conversation

@agnosticdev

Copy link
Copy Markdown
Collaborator

In the current pattern the QUICTransfer benchmark did not work due to ProtocolStreamHandlers having an empty upperReceiveQueue. Now the reads are scheduled on a new async block to give the original write time to unwind and process through the stack.

I double checked IPUDPTransfer, QUICHandshake, and QUICStreamLoad also and they seem to be fine.

@agnosticdev agnosticdev requested a review from rnro June 13, 2026 19:22
@tfpauly

tfpauly commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

I think the more correct solution here is to model off of what QUICStreamLoad does and use BridgeDatagramProtocol.

@agnosticdev

Copy link
Copy Markdown
Collaborator Author

I think the more correct solution here is to model off of what QUICStreamLoad does and use BridgeDatagramProtocol.

Yeah, we can deprecate the old pattern and migrate to BridgeDatagramProtocol. IPUDPTransfer still needs to adopt BridgeDatagramProtocol as well so I will open an issue there.

@agnosticdev agnosticdev merged commit 8939ae1 into main Jun 16, 2026
39 of 40 checks passed
@agnosticdev agnosticdev deleted the agnosticDev/FixQUICTransfer branch June 16, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants