Add peer address to N2_ConnectError trace events

[hsson]

The N2_ConnectError trace events were missing the peer IP address, making it difficult to identify which remote host failed to connect. This change adds PeerAddr and PeerAddress fields to all three N2_ConnectError logging locations in Net2.actor.cpp:

• Connection::connect() for regular TCP connections
• SSLConnection::connect() for TLS connections
• SSLConnection::connectWithHostname() for TLS with SNI

The BindPromise class already supported peer address logging, but setPeerAddr() was not being called for connection errors. This follows the same pattern used for other network error trace events (e.g., N2_ReadError, N2_WriteError, N2_AcceptHandshakeError) which already include peer address information.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

• The PR has a description, explaining both the problem and the solution.
• The description mentions which forms of testing were done and the testing seems reasonable.
• Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

• This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
• There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

[gxglass]

Thanks. The existing API seems obviously error-prone in retrospect. Do you think it would make sense to make the peer_address value be a parameter to the BindPromise constructor? Worst case, callers type NetworkAddress() and get a value with a bunch of zeros.

[hsson]

Thanks. The existing API seems obviously error-prone in retrospect. Do you think it would make sense to make the peer_address value be a parameter to the BindPromise constructor? Worst case, callers type NetworkAddress() and get a value with a bunch of zeros.

Thanks for the feedback, pushed another commit now that makes the peer address a mandatory parameter in the constructor! 🙂