Ddissue 7.3 by neethuhaneesha · Pull Request #12859 · apple/foundationdb

neethuhaneesha · 2026-03-26T01:51:53Z

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

… shards (apple#11324) Co-authored-by: Dan Lambright <[email protected]> Co-authored-by: Jingyu Zhou <[email protected]>

) (apple#11341) Co-authored-by: Chaoguang Lin <[email protected]>

…_fix Hex decode add-prefix and remove-prefix for fdbrestore.

* ConsistencyCheckerUrgent repeated run * address comments * avoid trace SevError for TesterRecruitmentTimeout unless it keeps failure for over 1 day * address comments * address comments

In the current code, errors are retried in getConsistentReadVersion, so it's possible that the client has cancelled the GRV request, but readVersionBatcher continue retrying, which can lead to many clients DDoS GRV proxies, especially when the database has become unavailable for a while and clients are issuing many GRV requests.

Throw errors in getConsistentReadVersion [release-7.3]

* Add logging to waitForVersion * Respond to review comments. --------- Co-authored-by: Dan Lambright <[email protected]>

Cherry-pick Add logging to LogRouter's waitForVersion function (apple#11359)

…cherry_pick [Release-7.3] Add documentation about experimental features

context (useful for running ycsb against bare metal cluster). * packaging/docker/Dockerfile * packaging/docker/Dockerfile.eks Make the ycsb target inherit from foundationdb-base so we pick up libfdb_c.so. Add in a version of run_ycsb.sh that doesn't presume k8s. Use 'entrypoint' rather than 'cmd' so can override on 'docker run'. * packaging/docker/run_ycsb_standalone.sh Version of run_ycsb.sh w/o the presumption of k8s.

* Disable fdb_test.go:TestOpenNotExistTenant This is not supported yet. * fixup! Fix the comment

[release-7.3] Add a knob for merge parallelism and add log for max shard size.

CC's checkBetterSingletons() calls getUsedIds() that asserts proxy interfaces are present. However, when a GRV/commit proxy failed, before CC starts a new recovery, the proxy's processId becomes empty, thus triggering the failure. The fix is to cancel the caller while waiting for recovery. To reproduce 7.1 commit 725a08a clang build: ./fdbserver.6.0.15 -r simulation -f ./tests/restarting/from_5.2.0_until_6.3.0/ClientTransactionProfilingCorrectness-1.txt -s 900000399 -b on -f ./tests/restarting/from_5.2.0_until_6.3.0/ClientTransactionProfilingCorrectness-2.txt --restarting -s 900000400 -b on

…er (apple#12475) * counters for dirty tags in TLogServer (apple#12427) * Make DirtyTagsProcessed count only tags that touch persistentData (apple#12468) Co-authored-by: Dan Lambright <[email protected]> --------- Co-authored-by: Dan Lambright <[email protected]>

* Delete blob tests and move some tests Specifically, moving from_7.3.50 to from_7.3.50_until_7.4.0, because Joshua contains 7.4 binaries and may cause "downgrade" issues. * Limit downgrade to _until_7.4.0 to avoid "downgrading" 7.4 * fix CMakeLists.txt

* Pass encryption file name to backup to encrypt backup files (apple#12287) * Backup encryption fix on S3 (apple#12289) * Backup encryption fix * Add enable_read_cache option to be selected randomly to cover both code paths. * Add randomization in ClientKnobs for testing * Enable Backup/Restore Encryption/Decryption in Simulation Tests (apple#12293) * Enable Backup Encryption in Simulation Tests * Enable encryption in BackupNew/OldRestore test and add fix * Enable encryption in BackupAndParallelRestoreCorrectness workload * Enable in RestoreBackup workload * Add additional workloads * Fix for Snap restart where second is not able to find if first run has encryption key or not. * Change the encryption probability to 50% in worloads * Format * Disable it in test and re-enable it later * Add metadata for Encrypted Backups (apple#12354) * Add metadata for Encrypted backups * Format files * Update error message in case of encryption keys mismatch for backup and restore (apple#12375) * Fix Backup Encryption File Access Flags (apple#12220) * fix flags * format Co-authored-by: Jingyu Zhou <[email protected]> * Delete line --------- Co-authored-by: Milla Samuel <[email protected]> Co-authored-by: Jingyu Zhou <[email protected]> --------- Co-authored-by: Milla Samuel <[email protected]> Co-authored-by: Milla Samuel <[email protected]> Co-authored-by: Jingyu Zhou <[email protected]>

apple#12590) * Provide encryption support with fdbbackup modify command * Update backup help * format * Fix errors * Error out if different encryption key files are passed for same url * Addressed comments

…#12619) (apple#12621)

* EncryptionBackup: Log encryption key file access failures at SevError severity (apple#12629) * Change the error to Sev40 * Fix formatting error * Display Encryption Key Info in status json (apple#12649) * Encryption in json * Addressed comments * Use unordered_set * Addressed comments for ctest

…ts (apple#12740)

foundationdb-ci · 2026-03-26T01:56:16Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 8c0f52d
Duration 0:04:11
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-26T01:56:58Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 8c0f52d
Duration 0:04:53
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-26T01:57:54Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 393da65
Duration 0:03:28
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-26T02:00:12Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 8c0f52d
Duration 0:08:09
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-03-26T02:00:12Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 8c0f52d
Duration 0:08:08
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-26T02:00:41Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 8c0f52d
Duration 0:08:37
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-26T02:01:39Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 393da65
Duration 0:07:16
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-26T02:02:29Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 393da65
Duration 0:08:07
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-03-26T02:02:32Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 393da65
Duration 0:08:08
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-26T02:02:38Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 393da65
Duration 0:08:16
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci and others added 30 commits April 26, 2024 21:17

update version after 7.3.41 release

dc95233

Cherry pick 11128 to 7.3 ensure synthetic data is written to existing…

3355ea3

… shards (apple#11324) Co-authored-by: Dan Lambright <[email protected]> Co-authored-by: Jingyu Zhou <[email protected]>

Replace the wrong usage of g_simulator in the snapshot code (apple#10984

8e9f859

) (apple#11341) Co-authored-by: Chaoguang Lin <[email protected]>

Hex decode add and remove prefixes for fdbrestore.

5d3e226

Review feedback.

681dada

Fix tab.

2c3bc06

Fix file headers.

146161a

Merge pull request apple#11344 from customerio/issue_1537_release_7_3…

e3a38fa

…_fix Hex decode add-prefix and remove-prefix for fdbrestore.

Improve distributed consistency checker (apple#11346) (apple#11349)

a7ca242

* ConsistencyCheckerUrgent repeated run * address comments * avoid trace SevError for TesterRecruitmentTimeout unless it keeps failure for over 1 day * address comments * address comments

Merge pull request apple#11353 from jzhou77/release-7.3

e662cf0

Throw errors in getConsistentReadVersion [release-7.3]

Adjusting block cache size knob. (apple#11357)

3541228

Add documentation about experimental features

adcb1a8

Add logging to LogRouter's waitForVersion function (apple#11359)

ae4b861

* Add logging to waitForVersion * Respond to review comments. --------- Co-authored-by: Dan Lambright <[email protected]>

Merge pull request apple#11365 from apple/r73-waitforversion

fa56304

Cherry-pick Add logging to LogRouter's waitForVersion function (apple#11359)

Merge pull request apple#11364 from PierreZ/pz/experimental_features_…

80897d4

…cherry_pick [Release-7.3] Add documentation about experimental features

fix ss queue rebalance (apple#11375) (apple#11378)

dad6ae1

[Release-7.3] Disable fdb_test.go:TestOpenNotExistTenant (apple#11381)

8f950f2

* Disable fdb_test.go:TestOpenNotExistTenant This is not supported yet. * fixup! Fix the comment

Improvements (apple#11362)

5d68250

RocksDB memtable max range deletions knob update. (apple#11387)

6c31d81

Disabling WRITE_CLIENT_LATENCY_TRACEEVENT knob (apple#11388)

7c7205e

shard size log

38d930f

Adjust knob.

fdcf673

Cherry pick PR 11385

67bd079

Merge pull request apple#11389 from yao-xiao-github/7.3-dd-cp

1919739

[release-7.3] Add a knob for merge parallelism and add log for max shard size.

Merge branch 'release-7.3' into r73-fixlogs

8a75d43

Respond to review comments

325967a

Add 7.1.58 to 7.1.61 release notes

928784f

kakaiu and others added 19 commits October 16, 2025 11:26

improve handshake error trace event (apple#12322) (apple#12469)

96ee1bc

Track temp tag message counts in TLogMetrics (apple#12471)

49e7e9c

Update previous FDB version to a more recent 7.1 version (apple#12552)

4a48d54

Provide encryption support with fdbbackup modify command (apple#12554) (

fa42419

apple#12590) * Provide encryption support with fdbbackup modify command * Update backup help * format * Fix errors * Error out if different encryption key files are passed for same url * Addressed comments

Add FileLevelEncryption field to BackupDescription JSON output (apple…

8f40ea4

…#12619) (apple#12621)

Release notes for 7.3.{72,73,74,75} (apple#12696)

3fbeca3

disable AVX for 7.3.72 release

ece484d

enable AVX and update version for 7.3.73 release

0e7cd1a

update version after 7.3.73 release

c84edb4

Use rocksdb 8.11.5 (apple#12690)

ce08c22

disable AVX for 7.3.74 release

0a3d53f

enable AVX and update version for 7.3.75 release

c9bb8f1

update version after 7.3.75 release

1d96ea1

Backup v2 pulling based on popVersion and disabling v2 simulation tes…

c99365d

…ts (apple#12740)

Adding a delay in getTeamByServers to prevent CPU monopolization

393da65

neethuhaneesha force-pushed the ddissue-7.3 branch from 8c0f52d to 393da65 Compare March 26, 2026 01:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ddissue 7.3#12859

Ddissue 7.3#12859
neethuhaneesha wants to merge 1025 commits intoapple:mainfrom
neethuhaneesha:ddissue-7.3

neethuhaneesha commented Mar 26, 2026

Uh oh!

foundationdb-ci commented Mar 26, 2026

Uh oh!

foundationdb-ci commented Mar 26, 2026

Uh oh!

foundationdb-ci commented Mar 26, 2026

Uh oh!

foundationdb-ci commented Mar 26, 2026

Uh oh!

foundationdb-ci commented Mar 26, 2026

Uh oh!

foundationdb-ci commented Mar 26, 2026

Uh oh!

foundationdb-ci commented Mar 26, 2026

Uh oh!

foundationdb-ci commented Mar 26, 2026

Uh oh!

foundationdb-ci commented Mar 26, 2026

Uh oh!

foundationdb-ci commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

neethuhaneesha commented Mar 26, 2026

Code-Reviewer Section

For Release-Branches

Uh oh!

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants