Add request data to invalidRequestWasReceived lifecycle event#7886
Open
Masadow wants to merge 1 commit intoapollographql:mainfrom
Open
Add request data to invalidRequestWasReceived lifecycle event#7886Masadow wants to merge 1 commit intoapollographql:mainfrom
invalidRequestWasReceived lifecycle event#7886Masadow wants to merge 1 commit intoapollographql:mainfrom
Conversation
|
@Masadow: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-server-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Member
|
This looks like a good improvement. It is backwards-compatible, so I'm not going to rush to get it in before releasing v5. It needs docs. |
Author
|
Hey it's been a while, I'm no longer working on the project requiring this so I highly doubt I will have time to commit to finish this. If anyone is interested and can take on the job here, it would be much appreciated 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I want to log all request made to my API and I'm not satisfied by the
didEncounterErrorsbecause it discards Bad Request event and such.By adding more the request object to
invalidRequestWasReceived, I will be able to log information regarding the malformed request such as body and headers that will help me trouble shoot issues.To give a concrete example, I currently have my API that is consumed by several client but one of them is intermittently spawning a lot of Bad Request issue. By having the ability to log all requests along with their headers and body content, I will be capable of identify the client that's causing the Bad Request.