Google Summer of code in the about section behaves as a link #462#465
Open
Inzamamdev wants to merge 1 commit intoapertium:masterfrom
Open
Google Summer of code in the about section behaves as a link #462#465Inzamamdev wants to merge 1 commit intoapertium:masterfrom
Inzamamdev wants to merge 1 commit intoapertium:masterfrom
Conversation
Contributor
|
why this pull request is waiting,sir? |
Member
|
It doesn't solve the problem in the correct way, in my opinion. The asset should be copied into the repo to avoid any future 404, same as the other images are. And setting both width and height shouldn't be necessary, as constraining just one dimension will let the browser scale it automatically. |
Author
|
Ok Thank you for instruction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolved The bug where the image was not visible