Open
Conversation
Contributor
Author
|
In this, I have taken streamparser.py from here. |
Member
Don't do this! Use a submodule. |
sushain97
requested changes
Aug 19, 2017
Member
sushain97
left a comment
There was a problem hiding this comment.
Please use a Git submodule for this so that upstream changes can be easily pulled in.
Merged
b36ac97 to
51fb9c5
Compare
e88afb1 to
ee3db28
Compare
fe64bac to
f22c450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of code from Kira-D's branch helped. Made a few changes for the logging part.