156 1mb error handling#179
Open
jounaidr wants to merge 3 commits into
Open
Conversation
tofu-rocketry
force-pushed
the
156-1mb-error-handling
branch
from
June 20, 2022 12:33
8dde520 to
a59e53c
Compare
Member
tofu-rocketry
force-pushed
the
156-1mb-error-handling
branch
from
August 2, 2022 09:18
a59e53c to
960f23c
Compare
Member
tofu-rocketry
force-pushed
the
156-1mb-error-handling
branch
2 times, most recently
from
December 12, 2022 17:06
4f9c095 to
e779fb4
Compare
tofu-rocketry
force-pushed
the
156-1mb-error-handling
branch
from
June 12, 2023 10:38
e779fb4 to
60e4eab
Compare
Member
No, I've not split it out yet. |
tofu-rocketry
force-pushed
the
156-1mb-error-handling
branch
from
June 12, 2023 12:03
60e4eab to
3921179
Compare
Implement code to stop send_all from clearing the message if it's too large.
Signed-off-by: jounaidr <jounaid.ruhomaun@stfc.ac.uk>
- Reorder argo_ams_library imports alphabetically. - Move comment to more logical position. - Change logging.warn to .warning as former is deprecating.
tofu-rocketry
force-pushed
the
156-1mb-error-handling
branch
from
June 12, 2023 15:14
3921179 to
e266757
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #156
Resolves #155
If AMS throws the specific 'message too large' exception, catch said exception and move the message to the rejected queue, and log this as a warning.
Logs when testing in dirq mode:
Logs when testing in directory mode (with valid messages before and after 'too large' message):