fix(syncer): retry status patches on latest object#2
Closed
weicao wants to merge 2 commits into
Closed
Conversation
Author
|
Closed in favor of #4. The status patch retry is folded into the complete restore handoff PR where needed for the same state machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ES PR loft-sh#2835 restore-runtime hit repeated PVC syncer status update conflicts while restore PVCs had DataProtection Backup dataSourceRef and virtual PVC status stayed Pending even though the restore PV path had materialized.
Observed syncer error shape:
Change
For status subresource updates, apply the calculated status patch to the latest live object and retry on Kubernetes conflicts.
Full-object updates keep the existing event-object semantics so syncers that intentionally overwrite fields do not become live-state merges.
Tests
go test ./pkg/patchergo test ./pkg/controllers/resources/persistentvolumeclaimsgo test ./pkg/controllers/resources/backupsgo test ./pkg/controllers/resources/persistentvolumesgo test ./pkg/controllers/resources/...Runtime Boundary
Local linux/amd64 sideload candidate built from commit
c1202e4e2asdocker.io/local/vcluster-es2835-status-retry:c1202e4e2.Image ID/digest:
Tarball on Derek's machine:
Local image smoke passed:
Not yet deployed to idc4 /
es-idc4-vc: this machine has no idc4 or ES vcluster kubeconfig context. Runtime closure still requires sideload + live syncer imageID + same-pin restore-runtime readback.