[ZEPPELIN-6358] Fix notebook UI bugs and add aria attributes and test IDs for selectors #5101#5133
Conversation
34b7b3b to
d89ed34
Compare
|
I realized the PR description might not be detailed enough for review, so here's a breakdown of each commit The "Find in Code" shortcut in a paragraph called The heading The Rename button had no disabled state, so users could clear the input and still submit. That sends an empty path to the backend via WebSocket ( Three things here:
|
|
@dididy Could you please rebase this? |
… IDs for selectors #5101 This PR fixes several notebook-related UI issues and improves testability and accessibility. - Fix an issue where the search menu trigger did not work correctly. - Prevent folder renaming when the input is empty by disabling the confirm button. - Add accessibility (ARIA) attributes and test-specific attributes to improve usability and E2E test stability. Bug Fix Refactoring ZEPPELIN-6358 * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5133 from dididy/e2e/notebook-bug. Signed-off-by: ChanHo Lee <chanholee@apache.org> (cherry picked from commit 5c35ad9) Signed-off-by: ChanHo Lee <chanholee@apache.org>
|
Thanks. I've merged this into master and branch-0.12 |
What is this PR for?
This PR fixes several notebook-related UI issues and improves testability and accessibility.
Changes
What type of PR is it?
Bug Fix
Refactoring
Todos
What is the Jira issue?
ZEPPELIN-6358
How should this be tested?
Screenshots (if appropriate)
Questions: