[Relax][ONNX] Fix Resize coordinate error with non-integer scales#19698
[Relax][ONNX] Fix Resize coordinate error with non-integer scales#19698cchung100m wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request preserves original spatial scales during ONNX frontend coordinate transformations to avoid lossy ratios, propagating scale overrides through the 1D, 2D, and 3D image resize operations in TOPI. Feedback on these changes highlights a critical typo (sacle_x_override) in resize.py that will cause a runtime NameError, the fact that the newly defined original_spatial_scales in onnx_frontend.py is never actually used or passed to the resize operators, and a minor PEP 8 style violation regarding spaces around keyword argument assignments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request preserves the original spatial scales in the ONNX frontend resize operations to prevent lossy coordinate transformations with non-integer scales. It updates TOPI resize functions to accept scale overrides and adds corresponding unit tests. The review feedback suggests fixing a typo in a comment and using topi_mode instead of relax_mode in the 3D resize implementation for consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Hi Committers,
This PR fixes issues #19570. Any suggestions would be appreciated if you are available.