Replace Bytecode with GremlinLang in .NET driver#3309
Open
xiazcy wants to merge 2 commits intodotnet-httpfrom
Open
Replace Bytecode with GremlinLang in .NET driver#3309xiazcy wants to merge 2 commits intodotnet-httpfrom
xiazcy wants to merge 2 commits intodotnet-httpfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces Bytecode with GremlinLang in the .NET Gremlin driver, aligning gremlin-dotnet with the 4.0 format already implemented in Java, Python, and Go.
3 new files were added, GremlinLang.cs, GValue.cs, and GremlinLangTests.cs. All files with Bytecode reference were replaced with GremlinLang. Bytecode specific files as well as all Groovy translator files were deleted.
Note this PR is opened against a feature branch for the 4.0 .NET driver, which will be merged into master after all components are completed. As well, current test are unit tests only, additional changes may be needed once HTTP protocol and serialization are properly implemented with Gherkin tests enabled.