feat(dashboard): add custom cover image for workflow cards#5704
Open
Ma77Ball wants to merge 7 commits into
Open
feat(dashboard): add custom cover image for workflow cards#5704Ma77Ball wants to merge 7 commits into
Ma77Ball wants to merge 7 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5704 +/- ##
============================================
- Coverage 52.91% 52.91% -0.01%
- Complexity 2626 2635 +9
============================================
Files 1090 1091 +1
Lines 42188 42289 +101
Branches 4531 4544 +13
============================================
+ Hits 22324 22376 +52
- Misses 18555 18598 +43
- Partials 1309 1315 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 391 | 0.238 | 26,102/33,922/33,922 us | 🟢 -15.1% / 🔴 +9.7% |
| 🔴 | bs=100 sw=10 sl=64 | 812 | 0.496 | 121,770/139,402/139,402 us | 🔴 +12.5% / 🔴 -9.0% |
| ⚪ | bs=1000 sw=10 sl=64 | 941 | 0.574 | 1,061,990/1,151,310/1,151,310 us | ⚪ within ±5% / 🔴 +12.5% |
Baseline details
Latest main dfa0434 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 391 tuples/sec | 393 tuples/sec | 410.82 tuples/sec | -0.5% | -4.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.238 MB/s | 0.24 MB/s | 0.251 MB/s | -0.8% | -5.1% |
| bs=10 sw=10 sl=64 | p50 | 26,102 us | 24,248 us | 23,785 us | +7.6% | +9.7% |
| bs=10 sw=10 sl=64 | p95 | 33,922 us | 39,965 us | 34,980 us | -15.1% | -3.0% |
| bs=10 sw=10 sl=64 | p99 | 33,922 us | 39,965 us | 34,980 us | -15.1% | -3.0% |
| bs=100 sw=10 sl=64 | throughput | 812 tuples/sec | 864 tuples/sec | 891.94 tuples/sec | -6.0% | -9.0% |
| bs=100 sw=10 sl=64 | MB/s | 0.496 MB/s | 0.527 MB/s | 0.544 MB/s | -5.9% | -8.9% |
| bs=100 sw=10 sl=64 | p50 | 121,770 us | 116,343 us | 112,277 us | +4.7% | +8.5% |
| bs=100 sw=10 sl=64 | p95 | 139,402 us | 123,872 us | 139,802 us | +12.5% | -0.3% |
| bs=100 sw=10 sl=64 | p99 | 139,402 us | 123,872 us | 139,802 us | +12.5% | -0.3% |
| bs=1000 sw=10 sl=64 | throughput | 941 tuples/sec | 954 tuples/sec | 1,041 tuples/sec | -1.4% | -9.6% |
| bs=1000 sw=10 sl=64 | MB/s | 0.574 MB/s | 0.582 MB/s | 0.635 MB/s | -1.4% | -9.7% |
| bs=1000 sw=10 sl=64 | p50 | 1,061,990 us | 1,049,812 us | 972,714 us | +1.2% | +9.2% |
| bs=1000 sw=10 sl=64 | p95 | 1,151,310 us | 1,104,869 us | 1,023,057 us | +4.2% | +12.5% |
| bs=1000 sw=10 sl=64 | p99 | 1,151,310 us | 1,104,869 us | 1,023,057 us | +4.2% | +12.5% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,512.09,200,128000,391,0.238,26102.42,33921.57,33921.57
1,100,10,64,20,2463.21,2000,1280000,812,0.496,121770.19,139402.28,139402.28
2,1000,10,64,20,21258.47,20000,12800000,941,0.574,1061990.33,1151309.76,1151309.76
Contributor
Author
|
/request-review @xuang7 @aglinxinyuan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
workflow_cover_image(wid, image)table (cover stored as a downscaled JPEG data URL, FK toworkflowwithON DELETE CASCADE) intexera_ddl.sqlplus asql/updates/25.sqlmigration.GET/PUT/DELETE /workflow/{wid}/coverendpoints onWorkflowResource: read access to fetch (404 when unset), write access to set/delete, with data-URL and size validation on set.WorkflowCoverService(frontend) that downscales/re-encodes the chosen file to a small JPEG data URL before upload, fetches the cover, and clears it.previewImagenow prefers the stored cover.Any related issues, documentation, discussions?
Closes: #5703
How was this PR tested?
WorkflowResourceCoverSpec(uses theMockTexeraDBembedded-Postgres harness) covers all three cover endpoints: 404 when unset, set/get round-trip, read by a user with read access, upsert replace, data-URL/blank/null/size validation rejections, read- and write-access gating, no-persist on validation failure, and idempotent delete. Runsbt "WorkflowExecutionService/testOnly *WorkflowResourceCoverSpec".WorkflowCoverServicespec covers GET mapping the image, 404 resolving to undefined, DELETE being issued, andsetCoverFromFilePUTting the resized data URL. Runcd frontend && yarn test --include='**/workflow-cover.service.spec.ts' --watch=false.CardItemComponentspec covers the cover behaviors (owner-in-private-search gating, cover load on init, default-image fallback, upload success / non-image rejection / upload failure, reset success / failure). Runcd frontend && yarn test --include='**/card-item.component.spec.ts' --watch=false.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF