test(frontend): add FormlyRepeatDndComponent unit tests#5632
Open
lie18uci wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
/request-review @Ma77Ball |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5632 +/- ##
============================================
- Coverage 52.78% 52.58% -0.21%
+ Complexity 2495 2479 -16
============================================
Files 1073 1072 -1
Lines 41382 41308 -74
Branches 4444 4440 -4
============================================
- Hits 21843 21720 -123
- Misses 18257 18311 +54
+ Partials 1282 1277 -5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xuang7
approved these changes
Jun 12, 2026
xuang7
left a comment
xuang7
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left one minor comment.
| import { CdkDragDrop } from "@angular/cdk/drag-drop"; | ||
| import { FormArray, FormControl } from "@angular/forms"; | ||
| import { ComponentFixture, TestBed } from "@angular/core/testing"; | ||
| import { vi } from "vitest"; |
Contributor
There was a problem hiding this comment.
This import may not be needed since vi is available globally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds frontend unit tests for
FormlyRepeatDndComponent.The new spec verifies that:
This improves test coverage for the drag-and-drop reorder behavior without changing existing component behavior.
Any related issues, documentation, discussions?
Closes #5464
How was this PR tested?
Ran the following command locally from the frontend directory:
yarn test --include='**/repeat-dnd.component.spec.ts'
The test passed successfully with 1 test file passed and 4 tests passed.
Also ran:
yarn lint
^ yarn lint completed successfully.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: ChatGPT