[SPARK-57707][PYTHON][TESTS] Skip doctest for shuffle#56795
Closed
gaogaotiantian wants to merge 2 commits into
Closed
[SPARK-57707][PYTHON][TESTS] Skip doctest for shuffle#56795gaogaotiantian wants to merge 2 commits into
gaogaotiantian wants to merge 2 commits into
Conversation
HyukjinKwon
approved these changes
Jun 26, 2026
uros-b
approved these changes
Jun 26, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
Thank you @gaogaotiantian and @HyukjinKwon!
dongjoon-hyun
approved these changes
Jun 26, 2026
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 26, 2026
### What changes were proposed in this pull request? Do not run doctest for shuffle. ### Why are the changes needed? The order of the array from shuffle is random, we should not assert the order. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Local test passed. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #56795 from gaogaotiantian/fix-shuffle-doctest. Authored-by: Tian Gao <gaogaotiantian@hotmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit d0d932a) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Thank you, @gaogaotiantian and all. Merged to master/4.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Do not run doctest for shuffle.
Why are the changes needed?
The order of the array from shuffle is random, we should not assert the order.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Local test passed.
Was this patch authored or co-authored using generative AI tooling?
No.