[SPARK-57434][SQL][TESTS] Move JavaGeographyTypeSuite and JavaGeometryTypeSuite to the Java test source root#56492
Closed
cloud-fan wants to merge 2 commits into
Closed
Conversation
…uite to the Java test source root JavaGeographyTypeSuite and JavaGeometryTypeSuite are Java (JUnit) test suites but live under `sql/core/src/test/scala/...`. Move them to the standard Java test source root `sql/core/src/test/java/...` (package unchanged), where Java test sources belong. Pure file relocation, no logic change. Co-authored-by: Isaac
Contributor
Author
|
cc @uros-db |
Member
There was a problem hiding this comment.
Although this is trivial, could you file a new JIRA issue for a better traceability if you are going to backporting this?
Since the original file was added at Apache Spark 4.1.0, I guess you want to backport. If this is only for Apache Spark 5.0+, it's okay to use MINOR.
cloud-fan
changed the title
Co-authored-by: Isaac
dongjoon-hyun
approved these changes
Jun 14, 2026
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @cloud-fan .
uros-b
approved these changes
Jun 14, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you @cloud-fan and @dongjoon-hyun!
Contributor
Author
|
thanks for review, merging to master/4.x/4.2/4.1! |
cloud-fan
added a commit
that referenced
this pull request
Jun 14, 2026
…TypeSuite to the Java test source root ### What changes were proposed in this pull request? Move `JavaGeographyTypeSuite` and `JavaGeometryTypeSuite` from `sql/core/src/test/scala/org/apache/spark/sql/types/` to `sql/core/src/test/java/org/apache/spark/sql/types/`. These are Java (JUnit) test suites that were placed under the Scala test source root when they were introduced in #52623 ([SPARK-53920]). This relocates them to the standard Java test source root. The package (`org.apache.spark.sql.types`) is unchanged and there is no logic change. ### Why are the changes needed? Java test sources belong under `src/test/java`, not `src/test/scala`. Keeping them in the Scala source tree is inconsistent with the standard Maven/SBT project layout. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. This is a pure file relocation with no logic change. ### Was this patch authored or co-authored using generative AI tooling? Yes, prepared with assistance from an AI coding agent. Closes #56492 from cloud-fan/move-java-geo-typesuites-to-java-root. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit c78c0c8) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
added a commit
that referenced
this pull request
Jun 14, 2026
…TypeSuite to the Java test source root ### What changes were proposed in this pull request? Move `JavaGeographyTypeSuite` and `JavaGeometryTypeSuite` from `sql/core/src/test/scala/org/apache/spark/sql/types/` to `sql/core/src/test/java/org/apache/spark/sql/types/`. These are Java (JUnit) test suites that were placed under the Scala test source root when they were introduced in #52623 ([SPARK-53920]). This relocates them to the standard Java test source root. The package (`org.apache.spark.sql.types`) is unchanged and there is no logic change. ### Why are the changes needed? Java test sources belong under `src/test/java`, not `src/test/scala`. Keeping them in the Scala source tree is inconsistent with the standard Maven/SBT project layout. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. This is a pure file relocation with no logic change. ### Was this patch authored or co-authored using generative AI tooling? Yes, prepared with assistance from an AI coding agent. Closes #56492 from cloud-fan/move-java-geo-typesuites-to-java-root. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit c78c0c8) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
added a commit
that referenced
this pull request
Jun 14, 2026
…TypeSuite to the Java test source root Move `JavaGeographyTypeSuite` and `JavaGeometryTypeSuite` from `sql/core/src/test/scala/org/apache/spark/sql/types/` to `sql/core/src/test/java/org/apache/spark/sql/types/`. These are Java (JUnit) test suites that were placed under the Scala test source root when they were introduced in #52623 ([SPARK-53920]). This relocates them to the standard Java test source root. The package (`org.apache.spark.sql.types`) is unchanged and there is no logic change. Java test sources belong under `src/test/java`, not `src/test/scala`. Keeping them in the Scala source tree is inconsistent with the standard Maven/SBT project layout. No. Existing tests. This is a pure file relocation with no logic change. Yes, prepared with assistance from an AI coding agent. Closes #56492 from cloud-fan/move-java-geo-typesuites-to-java-root. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit c78c0c8) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move
JavaGeographyTypeSuiteandJavaGeometryTypeSuitefromsql/core/src/test/scala/org/apache/spark/sql/types/tosql/core/src/test/java/org/apache/spark/sql/types/.These are Java (JUnit) test suites that were placed under the Scala test source
root when they were introduced in #52623 ([SPARK-53920]). This relocates them to
the standard Java test source root. The package (
org.apache.spark.sql.types)is unchanged and there is no logic change.
Why are the changes needed?
Java test sources belong under
src/test/java, notsrc/test/scala. Keepingthem in the Scala source tree is inconsistent with the standard Maven/SBT
project layout.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests. This is a pure file relocation with no logic change.
Was this patch authored or co-authored using generative AI tooling?
Yes, prepared with assistance from an AI coding agent.