Skip to content

[SPARK-57420][INFRA] Only generate TPC-DS data when required and check CPU compatibility early in benchmark workflow #56479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iemejia wants to merge 2 commits into
base: master
Choose a base branch
from
+25 −2
Open

[SPARK-57420][INFRA] Only generate TPC-DS data when required and check CPU compatibility early in benchmark workflow #56479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38d0394
[SPARK-57420][INFRA] Only generate TPC-DS data when required and chec…
iemejia Jun 12, 2026
1b52da5
Route expected-cpu input through env variable for shell safety
iemejia Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ on:
description: 'Commit the benchmark results to the current branch'
required: true
default: false
expected-cpu:
type: string
description: 'Expected CPU model (e.g. "AMD EPYC 7763"). If set, the job fails early when the runner CPU does not match.'
required: false
default: ''

jobs:
matrix-gen:
Expand All @@ -73,7 +78,10 @@ jobs:
# Any TPC-DS related updates on this job need to be applied to tpcds-1g job of build_and_test.yml as well
tpcds-1g-gen:
name: "Generate an TPC-DS dataset with SF=1"
if: contains(inputs.class, 'TPCDSQueryBenchmark') || contains(inputs.class, 'LZ4TPCDSDataBenchmark') || contains(inputs.class, 'ZStandardTPCDSDataBenchmark') || contains(inputs.class, '*')
# Only generate TPC-DS data when running TPC-DS benchmarks or all benchmarks (class == '*').
# Use exact equality instead of contains(inputs.class, '*') to avoid matching wildcard
# patterns like '*VectorizedDeltaReaderBenchmark' that don't need TPC-DS data.
if: contains(inputs.class, 'TPCDSQueryBenchmark') || contains(inputs.class, 'LZ4TPCDSDataBenchmark') || contains(inputs.class, 'ZStandardTPCDSDataBenchmark') || inputs.class == '*'
runs-on: ubuntu-latest
env:
SPARK_LOCAL_IP: localhost
Expand Down Expand Up @@ -156,6 +164,21 @@ jobs:
# In order to get diff files
with:
fetch-depth: 0
- name: Check CPU model
env:
EXPECTED_CPU: ${{ inputs.expected-cpu }}
run: |
CPU_MODEL=$(grep "model name" /proc/cpuinfo | head -1 | sed 's/model name\s*:\s*//')
echo "Runner CPU: $CPU_MODEL"
echo "::notice::Runner CPU: $CPU_MODEL"
if [ -n "$EXPECTED_CPU" ]; then
if echo "$CPU_MODEL" | grep -qF "$EXPECTED_CPU"; then
echo "CPU matches expected: $EXPECTED_CPU"
else
echo "::error::CPU mismatch! Expected '$EXPECTED_CPU' but got '$CPU_MODEL'"
exit 1
fi
fi
- name: Cache SBT and Maven
uses: actions/cache@v5
with:
Expand All @@ -179,7 +202,7 @@ jobs:
distribution: zulu
java-version: ${{ inputs.jdk }}
- name: Cache TPC-DS generated data
if: contains(inputs.class, 'TPCDSQueryBenchmark') || contains(inputs.class, 'LZ4TPCDSDataBenchmark') || contains(inputs.class, 'ZStandardTPCDSDataBenchmark') || contains(inputs.class, '*')
if: contains(inputs.class, 'TPCDSQueryBenchmark') || contains(inputs.class, 'LZ4TPCDSDataBenchmark') || contains(inputs.class, 'ZStandardTPCDSDataBenchmark') || inputs.class == '*'
id: cache-tpcds-sf-1
uses: actions/cache@v5
with:
Expand Down