Fix: LAL compiler treated (tag("x") as Integer) + (tag("y") as Integer) as string concatenation instead of numeric addition.#13857
Merged
wankai123 merged 2 commits intoapache:masterfrom Apr 30, 2026
Conversation
…er)` as string concatenation instead of numeric addition.
There was a problem hiding this comment.
Pull request overview
This PR fixes LAL (Log Analysis Language) code generation so that + between numerically cast operands (e.g., (tag("x") as Integer) + (tag("y") as Integer)) is emitted as numeric addition rather than forced string concatenation, ensuring numeric comparisons in conditions behave correctly.
Changes:
- Update LAL value codegen to detect all-numeric
+operand lists and emitlongarithmetic (with boxing for non-comparison contexts). - Add unit tests covering integer/long arithmetic sums in conditions and ensuring uncast
+remains string concatenation. - Add a changelog entry describing the fix and its impact.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
oap-server/analyzer/log-analyzer/src/main/java/.../LALValueCodegen.java |
Detects numeric + operands and generates long arithmetic instead of "" + ... concatenation. |
oap-server/analyzer/log-analyzer/src/test/java/.../LALClassGeneratorConditionTest.java |
Adds tests validating arithmetic-vs-concat codegen output in relevant DSL patterns. |
docs/en/changes/changes.md |
Documents the bug fix in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wu-sheng
previously approved these changes
Apr 30, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wu-sheng
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a unit test to verify that the fix works.
Explain briefly why the bug exists and how to fix it.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
Update the
CHANGESlog.