Helm CI: wait for fixture database readiness before ct install#4604
Merged
Conversation
MonkeyCanCode
approved these changes
Jun 3, 2026
github-project-automation
Bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Contributor
|
Changes looks good. Thanks @venkateshwaracholan . |
nandorKollar
approved these changes
Jun 3, 2026
adutra
approved these changes
Jun 3, 2026
github-project-automation
Bot
moved this from Ready to merge
to Done
in Basic Kanban Board
MonkeyCanCode
pushed a commit
to MonkeyCanCode/polaris
that referenced
this pull request
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4601.
Helm CI applied fixture databases and immediately ran ct install, while local workflows (make helm-fixtures) and developer docs wait for PostgreSQL and MongoDB pods to become Ready first.
This adds the same kubectl wait steps to CI before chart-testing install.
No production or chart behavior changes.
What changed
After kubectl apply for helm/polaris/ci/fixtures, CI now waits for:
app.kubernetes.io/name=postgres
app.kubernetes.io/name=mongodb
in namespace polaris-ns (120s timeout), matching the selectors already used in the Makefile and helm-chart/dev.md.
Notes
Fixture YAML confirms both Deployments use these labels, run at replicas: 1, and define readiness probes — so --for=condition=ready pod is appropriate.
This aligns CI with documented local practice. It may reduce Helm CI flakes when persistence scenarios start before databases are accepting connections, but I have not tied it to a specific past CI failure.
Test plan
CI Helm chart-testing job passes
Verified fixture labels/selectors in:
helm/polaris/ci/fixtures/postgres.yaml
helm/polaris/ci/fixtures/mongodb.yaml
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)