[tantivy] Reuse TantivySearcher across queries via searcher pool#7671
Open
chenghuichen wants to merge 7 commits intoapache:masterfrom
Open
[tantivy] Reuse TantivySearcher across queries via searcher pool#7671chenghuichen wants to merge 7 commits intoapache:masterfrom
chenghuichen wants to merge 7 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Each full-text search query currently opens a fresh
TantivySearcher, which rebuilds the Rust-side index structures (including loading the.termFST dictionary) from scratch. On object storage (S3/OSS), this means a full GET of the index file on every query. In Flink streaming pipelines — the primary JVM consumer of Paimon's global index — the same index shard is queried continuously within a single subtask lifetime, making repeated loading pure waste.This PR introduces a
TantivySearcherPoolthat keepsTantivySearcherinstances alive across queries, borrowing on query start and returning on close rather than destroying and rebuilding.Benefit Assessment
Benchmark on local disk (500k docs, 17MB index, 500 queries, JIT-warmed):
On object storage the gap widens further: the open phase includes a full GET of the
.termfile (FST dictionary, typically several MB per shard). With the pool,.termstays resident in Rust memory across queries, eliminating both the latency and the object storage data transfer cost of repeated loading. For tables under heavy compaction, index files are replaced by new paths; stale pool entries go unused without affecting correctness.Tests