libc/stdio: fix freopen fd handling and add fdsan support #17910
+28
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
freopen()implementation:Close old fd before reopening: The previous implementation opened the new file first, then used
dup2()to replace the old fd. This approach has issues:dup2()closes it implicitlyopen()anddup2()The new implementation closes the old fd first, then opens the new file. This allows the kernel to reuse the same fd number, avoiding the need for
dup2().Add fdsan support: When CONFIG_FDSAN is enabled, properly handle fd ownership tags:
android_fdsan_close_with_tag()to close the old fd with correct ownershipandroid_fdsan_exchange_owner_tag()to set ownership on the new fdImpact
freopen()freopen()callsTesting
freopen()works correctly with and without CONFIG_FDSANfreopen()