net/can: allow errmask to be set to CAN_ERR_FLAG #17907
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the LIN protocol, the error frame ID can be 0. This change is to ensure that all LIN error frames can pass the filter. Signed-off-by: wangjinjing1 <[email protected]>
jwang12340
requested review from
Donny9,
raiden00pl and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: Networking
acassis
reviewed
Jan 14, 2026
| } | ||
|
|
||
| conn->err_mask = *(FAR can_err_mask_t *)value & CAN_ERR_MASK; | ||
| conn->err_mask = *(FAR can_err_mask_t *)value; |
Contributor
There was a problem hiding this comment.
@jwang12340 what is the relation between LIN and the CAN driver? I think this are different things. BTW where is the LIN support you are referring to?
Author
There was a problem hiding this comment.
LIN and CAN are different on driver level, but above in software protocal level the lin frame can be process by socket CAN with standard CAN protocal, LIN related flags are defined in "include/nuttx/lin.h".
Contributor
|
@pkarashchenko since you working with LIN, could you please a look? I'm confuse about this CAN and LIN correlation. I think they should be different things |
xiaoxiang781216
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
This change is to allow errmask to be set to CAN_ERR_FLAG, so that error frames with id 0 can also pass the err filter.
e,g, for LIN protocol, the error frame ID can be 0.
Impact
socketcan err mask