Skip to content

net: make the sendmsg param type consistent with posix specification #17858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GUIDINGLI merged 2 commits into from
Jan 16, 2026
Merged

net: make the sendmsg param type consistent with posix specification #17858

GUIDINGLI merged 2 commits into from
Jan 16, 2026
+45 −43

Conversation

@extinguish
Copy link
Contributor

@extinguish extinguish commented Jan 13, 2026

Summary

Update the sendmsg() socket API and its relative functions to use const-qualified message header parameters, aligning the implementation with the POSIX specification.

Impact

Improves API compliance with the POSIX standard, which defines sendmsg() as taking a const struct msghdr *

Testing

Verified that existing code compiles without warnings or errors after the change

@extinguish
net: make the sendmsg param type consistent with posix specification
cb43db0 
To ensure consistency, in all places where the "sendmsg" function is used
either directly or indirectly, the type of the "struct msghdr *msg" parameter
needs to be modified to "const struct msghdr *msg".

Signed-off-by: guoshichao <[email protected]>
@github-actions github-actions bot added Area: Networking Effects networking subsystem Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Jan 13, 2026
@extinguish
can_sendmsg_buffered: fix can_sendmsg param type mismatch error
433fe87 
Update the can_sendmsg() signature from "struct msghdr *msg" to
"const struct msghdr *msg" to match the updated sendmsg() prototype
and resolve compilation errors due to parameter type inconsistency.

Signed-off-by: guoshichao <[email protected]>
@simbit18
Copy link
Contributor

simbit18 commented Jan 13, 2026

hi @extinguish this error has occurred.

====================================================================================
Configuration/Tool: photon/adb,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2026-01-13 10:23:22
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Building NuttX...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100 44130  100 44130    0     0   162k      0 --:--:-- --:--:-- --:--:--  162k

100 1646k  100 1646k    0     0  5591k      0 --:--:-- --:--:-- --:--:-- 5591k
chip/stm32_gpio.c:44:11: note: '#pragma message: CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated migrate board.h see tools/stm32_pinmap_tool.py'
   44 | #  pragma message "CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated migrate board.h see tools/stm32_pinmap_tool.py"
      |           ^~~~~~~
Error: libuv/src/unix/nuttx.c:225:9: error: conflicting types for 'sendmsg'; have 'ssize_t(int,  struct msghdr *, int)' {aka 'int(int,  struct msghdr *, int)'}
  225 | ssize_t sendmsg(int sockfd, struct msghdr *msg, int flags) {
      |         ^~~~~~~
In file included from /github/workspace/sources/apps/system/libuv/libuv/include/uv/unix.h:30,
                 from /github/workspace/sources/apps/system/libuv/libuv/include/uv.h:71,
                 from libuv/src/uv-common.h:35,
                 from libuv/src/unix/internal.h:25,
                 from libuv/src/unix/nuttx.c:26:
/github/workspace/sources/nuttx/include/sys/socket.h:465:9: note: previous declaration of 'sendmsg' with type 'ssize_t(int,  const struct msghdr *, int)' {aka 'int(int,  const struct msghdr *, int)'}
  465 | ssize_t sendmsg(int sockfd, FAR const struct msghdr *msg, int flags);
      |         ^~~~~~~
make[2]: *** [/github/workspace/sources/apps/Application.mk:239: nuttx.c.github.workspace.sources.apps.system.libuv.o] Error 1
make[2]: Target 'all' not remade because of errors.
make[1]: *** [Makefile:54: /github/workspace/sources/apps/system/libuv_all] Error 2
make[1]: Target 'all' not remade because of errors.
make: *** [tools/LibTargets.mk:248: /github/workspace/sources/apps/libapps.a] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
  [1/1] Normalize photon/adb
====================================================================================

@extinguish
Copy link
Contributor Author

extinguish commented Jan 14, 2026 •
edited
Loading

hi @extinguish this error has occurred.

====================================================================================
Configuration/Tool: photon/adb,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2026-01-13 10:23:22
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Building NuttX...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100 44130  100 44130    0     0   162k      0 --:--:-- --:--:-- --:--:--  162k

100 1646k  100 1646k    0     0  5591k      0 --:--:-- --:--:-- --:--:-- 5591k
chip/stm32_gpio.c:44:11: note: '#pragma message: CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated migrate board.h see tools/stm32_pinmap_tool.py'
   44 | #  pragma message "CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated migrate board.h see tools/stm32_pinmap_tool.py"
      |           ^~~~~~~
Error: libuv/src/unix/nuttx.c:225:9: error: conflicting types for 'sendmsg'; have 'ssize_t(int,  struct msghdr *, int)' {aka 'int(int,  struct msghdr *, int)'}
  225 | ssize_t sendmsg(int sockfd, struct msghdr *msg, int flags) {
      |         ^~~~~~~
In file included from /github/workspace/sources/apps/system/libuv/libuv/include/uv/unix.h:30,
                 from /github/workspace/sources/apps/system/libuv/libuv/include/uv.h:71,
                 from libuv/src/uv-common.h:35,
                 from libuv/src/unix/internal.h:25,
                 from libuv/src/unix/nuttx.c:26:
/github/workspace/sources/nuttx/include/sys/socket.h:465:9: note: previous declaration of 'sendmsg' with type 'ssize_t(int,  const struct msghdr *, int)' {aka 'int(int,  const struct msghdr *, int)'}
  465 | ssize_t sendmsg(int sockfd, FAR const struct msghdr *msg, int flags);
      |         ^~~~~~~
make[2]: *** [/github/workspace/sources/apps/Application.mk:239: nuttx.c.github.workspace.sources.apps.system.libuv.o] Error 1
make[2]: Target 'all' not remade because of errors.
make[1]: *** [Makefile:54: /github/workspace/sources/apps/system/libuv_all] Error 2
make[1]: Target 'all' not remade because of errors.
make: *** [tools/LibTargets.mk:248: /github/workspace/sources/apps/libapps.a] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
  [1/1] Normalize photon/adb
====================================================================================

this pull request need to pass CI together with apache/nuttx-apps#3324, can these two pull requests pass CI together?

@GUIDINGLI GUIDINGLI merged commit 3d45550 into apache:master Jan 16, 2026
52 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@GUIDINGLI GUIDINGLI GUIDINGLI approved these changes

@pussuw pussuw Awaiting requested review from pussuw pussuw is a code owner

@jerpelea jerpelea Awaiting requested review from jerpelea jerpelea is a code owner

@Donny9 Donny9 Awaiting requested review from Donny9 Donny9 is a code owner

@pkarashchenko pkarashchenko Awaiting requested review from pkarashchenko pkarashchenko is a code owner

@Ouss4 Ouss4 Awaiting requested review from Ouss4 Ouss4 is a code owner

@btashton btashton Awaiting requested review from btashton btashton is a code owner

Assignees

No one assigned

Labels

Area: Networking Effects networking subsystem Area: OS Components OS Components issues Size: S The size of the change in this PR is small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@extinguish @simbit18 @xiaoxiang781216 @GUIDINGLI