Backport changes to 10x branch to add and enforce fallback support when full precision vectors not present in index #15588
+613
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly quantized vectors are present (apache#14792)
…vector formats (apache#15476) * Moved testReadQuantizedVectorWithEmptyRawVectors test case to BaserKnnVectorsFormatTestCase * Added entry to Changes.txt * Rename function * Made helper functions protected * CHanged function name and remove redundanct vector copying * Moved helper methods to subclasses to have codec specific implementation * Revert "Moved helper methods to subclasses to have codec specific implementation" This reverts commit f0c66d6. * Moved helper methods to subclasses to have codec specific implementation which supports fallback * remove unused constant * Made functions private from protected * Moved indexWriter to try block --------- Co-authored-by: Pulkit Gupta <[email protected]>
Member
|
@Pulkitg64 I think this is good to backport. Resolve conflicts? I can merge this. @mikemccand unless you have any outstanding concerns. |
Contributor
Author
|
Thanks @benwtrent, I have resolved the conflict. |
Member
|
Thank you @Pulkitg64 and @benwtrent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we are backporting below changes to 10x branch to add and enforce fallback support when full precision vectors not present in index: