[KYUUBI #7590][SPARK] Exit engine when SparkContext stops - #7592
Closed
turboFei wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Closes #7590.
After
SparkContextstops, engine shutdown can stall beforestopServerreleases themain-thread latch. In that state,
SparkSQLEnginewaits indefinitely and leaves azombie engine process.
This patch checks the
SparkContextstate while waiting for normal engine shutdown.It also rechecks the latch before reporting failure so that a concurrent normal
shutdown wins the race.
How was this patch tested?
Added tests for both the stopped-
SparkContextpath and the concurrent normal-shutdownpath.
mvn test -pl :kyuubi-spark-sql-engine_2.12 -am \ -Dtest=none \ -DwildcardSuites=org.apache.kyuubi.engine.spark.SparkSQLEngineSuiteResult: 3 tests passed.
Also ran the repository Spotless formatter.
Was this patch authored or co-authored using generative AI tooling?
Assisted-by: OpenAI Codex with GPT-5