KAFKA-19988: change example kafka-storage command in the migration section #21137
Merged
chia7712 merged 1 commit intoapache:3.9from Dec 27, 2025
Merged
KAFKA-19988: change example kafka-storage command in the migration section #21137chia7712 merged 1 commit intoapache:3.9from
chia7712 merged 1 commit intoapache:3.9from
Conversation
Author
|
Currently ops.html is out of sync between kafka 3.9 and kafka-site. What I gathered is the following:
All in all the section about the kafka-storage tool command is still missing from ops.html in kafka. I included in my PR since I have to modify it anyway and this way there is no chance for an accidental removal from kafka-site. |
Member
|
@harmadasg would you mind fixing the conflicts? |
…ration section to account for zookeeper based cluster ids with a leading dash
ab1cdb3 to
cc85763
Compare
Author
|
@chia7712 oh I see in the meantime the markdown docs change was also applied to 3.9. fixed the conflicts |
chia7712
approved these changes
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When preparing for the migration, there is a small chance that the retrieved cluster id from ZooKeeper contains a leading dash. Currently the 3.9 documentation specifies the following during the step "Provisioning the KRaft controller quorum":
However the above command will fail with a less fortunate cluster id like
-Yh6XyBIQ9CeAlMwJ8f7Hg, eg.:A similar problem came up with KRaft which was addressed in KAFKA-13741. In our case the cluster id is already specified, there is no way to change it. I was able to come up with a simple solution by using the full name of the argument like
--cluster-id=<zk-cluster-id>instead of the shorthand-t <zk-cluster-id>. Full example:I would propose to change the documentation based on my findings so we will be able to cover also ZooKeeper based cluster ids with a leading dash.
Reviewers: Chia-Ping Tsai chia7712@gmail.com