Skip to content

MINOR: Clean up TopicCommand#21121

Merged
chia7712 merged 1 commit intoapache:trunkfrom
wernerdv:clean_topic_command
Jan 21, 2026
Merged

MINOR: Clean up TopicCommand#21121
chia7712 merged 1 commit intoapache:trunkfrom
wernerdv:clean_topic_command

Conversation

@wernerdv
Copy link
Contributor

@wernerdv wernerdv commented Dec 10, 2025

Changes in this PR:

  • Cleared out obsolete boolean fields (always false) from classes.
  • Revised method access modifiers for better encapsulation.
  • Simplified code by inlining one‑time‑use methods.

Reviewers: Chia-Ping Tsai [email protected]

@github-actions github-actions bot added triage PRs from the community tools labels Dec 10, 2025
@wernerdv
Copy link
Contributor Author

@AndrewJSchofield @apoorvmittal10 Hello, could you please take a look when you have a chance?

@github-actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@wernerdv
Copy link
Contributor Author

@chia7712 gentle ping for review

@github-actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@wernerdv wernerdv force-pushed the clean_topic_command branch from 8e634ec to bb1d4cf Compare January 3, 2026 16:34
@wernerdv
Copy link
Contributor Author

wernerdv commented Jan 3, 2026

@chia7712 Please take a look at the small cleanup when you have a chance.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

this.numPartitions = numPartitions;
this.replicationFactor = replicationFactor;
this.config = config;
this.markedForDeletion = markedForDeletion;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. This was a zk-speicific deletion marker, so it is redundant now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

@chia7712 chia7712 merged commit 5f59eac into apache:trunk Jan 21, 2026
26 checks passed
@wernerdv wernerdv deleted the clean_topic_command branch January 21, 2026 08:20
@github-actions github-actions bot removed needs-attention triage PRs from the community labels Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants