fix: avoid using C-style pointers to prevent potential memory leaks#913
Open
SYaoJun wants to merge 3 commits intoapache:mainfrom
Open
fix: avoid using C-style pointers to prevent potential memory leaks#913SYaoJun wants to merge 3 commits intoapache:mainfrom
SYaoJun wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
|
pleas fix that. |
Signed-off-by: syaojun <libevent@yeah.net>
Signed-off-by: syaojun <libevent@yeah.net>
Signed-off-by: syaojun <libevent@yeah.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
============================================
- Coverage 80.60% 80.58% -0.02%
Complexity 615 615
============================================
Files 94 94
Lines 10709 10698 -11
Branches 1055 1055
============================================
- Hits 8632 8621 -11
Misses 1837 1837
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
current
Statusmissing copy assignment operator, which may cause memory leak.modern cpp guidelines suggent using smart pointer instead of C-type pointer.
In this PR, it uses
std::unique_ptr<State> state_;to replace orignalState* state_;BTW, This memory leak was detected by
.clang-tidy.#898
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?