Skip to content

fix: handle silently ignored errors in migration helper and pipeline cancel#8773

Closed
warren830 wants to merge 2 commits intomainfrom
fix/silent-error-handling
Closed

fix: handle silently ignored errors in migration helper and pipeline cancel#8773
warren830 wants to merge 2 commits intomainfrom
fix/silent-error-handling

Conversation

@warren830
Copy link
Contributor

Summary

  • In AutoMigrateTables, properly handle db.First errors instead of silently discarding them — NotFound is expected for empty tables but other errors (e.g. connection issues) should be surfaced
  • In CancelPipeline, log task cancellation failures instead of silently ignoring them with _ = CancelTask()

Test plan

  • Verify AutoMigrateTables works correctly for both empty and populated tables
  • Verify pipeline cancellation logs errors for individual task cancel failures
  • Verify existing migration scripts still pass

…cancel

In AutoMigrateTables, properly handle db.First errors instead of silently
discarding them — NotFound is expected for empty tables but other errors
should be surfaced. In CancelPipeline, log task cancellation failures
instead of silently ignoring them.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. component/framework This issue or PR relates to the framework improvement pr-type/bug-fix This PR fixes a bug labels Mar 16, 2026
@warren830 warren830 closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/framework This issue or PR relates to the framework improvement pr-type/bug-fix This PR fixes a bug size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant