feat(inspect): add base metadata table interface#607
Merged
Conversation
wgtmac
reviewed
Apr 2, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this! I've left some preliminary comments.
wgtmac
reviewed
May 11, 2026
Member
|
Please rebase to resolve conflicts. Let me know when it is ready to review again. |
wgtmac
added
the
awaiting author action
Member
|
Could you please make ci happy (and possibly rebase on the latest main branch)? |
wgtmac
reviewed
Jun 14, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
Please also fix the current CI failure before merging.
wgtmac
removed
the
awaiting author action
wgtmac
changed the title
wgtmac
approved these changes
Jun 15, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
I thought the design could be simplified if MetadataTable doesn't inherit Table so I just made this change to reflect this. I've also simplified the factory and public functions. Since this PR has been opened too long, I'll merge it to move forward. Thanks @All-less for initiating this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR kicks off the implementation of table inspection support.
BaseMetadataTableclass (without scan support for now).MetadataTableFactoryas an entry point for creating metadata tables.SnapshotsTableandHistoryTableas example impl.