Skip to content

[#10964] feat(authn): Implement Basic authentication flow#10973

Open
lasdf1234 wants to merge 15 commits into
apache:mainfrom
lasdf1234:feat/basic-auth-flow-10964
Open

[#10964] feat(authn): Implement Basic authentication flow#10973
lasdf1234 wants to merge 15 commits into
apache:mainfrom
lasdf1234:feat/basic-auth-flow-10964

Conversation

@lasdf1234
Copy link
Copy Markdown
Contributor

@lasdf1234 lasdf1234 commented May 5, 2026

What changes were proposed in this pull request?

This PR implements the Basic authentication flow for local authentication. It verifies Basic credentials against the local IdP user metadata, checks the stored password hash, and keeps malformed header handling covered by tests.

Why are the changes needed?

The local authentication epic needs the Basic authenticator to validate username/password credentials end-to-end instead of only parsing the Authorization header.

Fix: #10964

Does this PR introduce any user-facing change?

Users can now authenticate with Basic authentication when local authentication is enabled and the provided username/password matches the stored local IdP user metadata.

How was this patch tested?

./gradlew :server-common:test --tests org.apache.gravitino.server.authentication.TestBasicAuthenticator --tests org.apache.gravitino.server.authentication.TestAuthenticationFilter -PskipITs -PskipDockerTests=true

lasdf1234 and others added 15 commits May 4, 2026 22:07
…-auth-password-hashing

# Conflicts:
#	authenticators/authenticator-basic/build.gradle.kts
#	server-common/src/main/java/org/apache/gravitino/server/authentication/Argon2idPasswordHasher.java
#	server-common/src/main/java/org/apache/gravitino/server/authentication/PasswordHasher.java
#	server-common/src/main/java/org/apache/gravitino/server/authentication/PasswordHasherFactory.java
#	server-common/src/test/java/org/apache/gravitino/server/authentication/TestArgon2idPasswordHasher.java
Move service admin initialization into authenticator-basic and wire it through a ServerAuthenticator-style singleton initializer.\n\nCo-authored-by: Copilot <[email protected]>
Copilot AI review requested due to automatic review settings May 5, 2026 16:59
@lasdf1234 lasdf1234 changed the title [#10964] feat(authentication): implement Basic authentication flow feat(authentication): Implement Basic authentication flow May 5, 2026
@lasdf1234 lasdf1234 changed the title feat(authentication): Implement Basic authentication flow [#10964] feat(authentication): Implement Basic authentication flow May 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@lasdf1234 lasdf1234 changed the title [#10964] feat(authentication): Implement Basic authentication flow [#10964] feat(authn): Implement Basic authentication flow May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subtask] Initialize service admins

2 participants