[FLINK-37924][table]Introduce Built-in Function to Access field or element in the Variant#27330
Conversation
…ement in the Variant
efb13bf to
53f4993
Compare
.../java/org/apache/flink/table/types/inference/strategies/ItemAtIndexArgumentTypeStrategy.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/flink/table/types/inference/strategies/ItemAtIndexArgumentTypeStrategy.java
Outdated
Show resolved
Hide resolved
...-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
Show resolved
Hide resolved
...src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/VariantSemanticTest.java
Show resolved
Hide resolved
…ues with incorrect types
c27b41a to
e036ebc
Compare
|
Hello @Sxnan Could you take a look at this PR when you have time? Thanks |
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Thanks for the PR @JinkunLiu. Left some comments as below.
...mmon/src/main/java/org/apache/flink/table/types/inference/strategies/ItemAtTypeStrategy.java
Outdated
Show resolved
Hide resolved
...planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
Outdated
Show resolved
Hide resolved
...planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
Outdated
Show resolved
Hide resolved
...-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala
Show resolved
Hide resolved
flink-table/flink-sql-parser/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java
Outdated
Show resolved
Hide resolved
|
Hi @yunfengzhou-hub, thanks for the review! I have updated the code according to your suggestions. Could you please take another look at this PR when you have time? Thank you very much! |
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Thanks for the update. Generally LGTM. Some minor comments are as below.
.../java/org/apache/flink/table/types/inference/strategies/ItemAtIndexArgumentTypeStrategy.java
Show resolved
Hide resolved
...flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala
Outdated
Show resolved
Hide resolved
|
Hi @davidradl , thanks for the review! Could you take an another look. Thanks |
xuyangzhong
left a comment
There was a problem hiding this comment.
Thanks for driving this. This pr LGTM overall. I just left some minor comments.
.../java/org/apache/flink/table/types/inference/strategies/ItemAtIndexArgumentTypeStrategy.java
Outdated
Show resolved
Hide resolved
...planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-parser/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java
Show resolved
Hide resolved
d08b908 to
26d8f28
Compare
xuyangzhong
left a comment
There was a problem hiding this comment.
Thanks for updating, just one more minor comment.
What is the purpose of the change
Introduce a built-in function to access a field or element in a Variant. This is part of FLIP-521.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
org.apache.flink.table.planner.plan.nodes.exec.stream.VariantSemanticTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)