Skip to content

feature: 指定某一列，当相邻单元格内容一致时合并处理#256

Open
long-chin wants to merge 1 commit into
apache:mainfrom
long-chin:main
Open

feature: 指定某一列，当相邻单元格内容一致时合并处理#256
long-chin wants to merge 1 commit into
apache:mainfrom
long-chin:main

Conversation

@long-chin

@long-chin long-chin commented Mar 8, 2025

Copy link
Copy Markdown

No description provided.

@psxjoy

psxjoy commented Mar 8, 2025

Copy link
Copy Markdown
Member

Hi, IMO: This functionality can be tailored by users as needed.
For those with specific requirements, a custom implementation is feasible.
Should we consider integrating it into the default strategy?

@psxjoy psxjoy added the pending This problem needs to be confirmed label Mar 8, 2025
@psxjoy psxjoy self-requested a review March 8, 2025 13:26
psxjoy
psxjoy requested changes Mar 8, 2025
View reviewed changes
Comment thread fastexcel-core/src/main/java/cn/idev/excel/write/merge/DynamicMergeStrategy.java Outdated
Comment thread fastexcel-core/src/main/java/cn/idev/excel/write/merge/DynamicMergeStrategy.java Outdated
Comment thread fastexcel-core/src/main/java/cn/idev/excel/write/merge/DynamicMergeStrategy.java Outdated
Comment thread fastexcel-test/src/test/java/cn/idev/excel/test/demo/write/WriteTest.java Outdated
@long-chin

long-chin commented Mar 8, 2025

Copy link
Copy Markdown
Author

Your suggestion is very good, I will revise it and submit it again

@psxjoy

psxjoy commented Mar 10, 2025

Copy link
Copy Markdown
Member

Hi, maybe I wasn't clear enough. Kindly delete the author information and refrain from including any personal developer specifics :)

@psxjoy

psxjoy commented Apr 22, 2025

Copy link
Copy Markdown
Member

Update: In the code review process.

@psxjoy psxjoy added the enhancement New feature or request label Apr 22, 2025
wangmiscoding
wangmiscoding reviewed Jul 3, 2025
View reviewed changes

@wangmiscoding wangmiscoding left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the code is not formatted, and the character spacing is not consistent

@delei

delei commented Jul 31, 2025

Copy link
Copy Markdown
Member

Hi, @long-chin
Thank you for submitting this PR!

We should resolve conflicts first, and please modify the commit message to better comply with the commit guidelines,and use English for commit messages.
e.g., feat: xxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psxjoy psxjoy psxjoy requested changes
@jipengfei-jpf jipengfei-jpf Awaiting requested review from jipengfei-jpf
+1 more reviewer
@wangmiscoding wangmiscoding wangmiscoding left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request pending This problem needs to be confirmed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@long-chin @psxjoy @delei @wangmiscoding