Skip to content

[Chore](build) fix conflict field id #60743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hello-stephen merged 1 commit into from
Feb 13, 2026
+2 −1
Merged

[Chore](build) fix conflict field id #60743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gensrc/thrift/PaloInternalService.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,14 +425,15 @@ struct TQueryOptions {
184: optional i32 cte_max_recursion_depth;

185: optional bool enable_parquet_file_page_cache = true;
186: optional bool enable_aggregate_function_null_v2 = false;

186: optional bool enable_streaming_agg_hash_join_force_passthrough;

187: optional bool enable_distinct_streaming_agg_force_passthrough;

188: optional bool enable_broadcast_join_force_passthrough;

189: optional bool enable_aggregate_function_null_v2 = false;
Comment on lines 433 to +435
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does more than reorder fields: it changes the Thrift field id for enable_aggregate_function_null_v2 from 186 to 189. That alters the wire serialization contract, so the PR description claiming “no functionality is affected” is inaccurate; please update the description (and release notes if required) to reflect the compatibility impact and rationale for picking the new id.

Copilot uses AI. Check for mistakes.
Comment on lines 429 to +435
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing a TQueryOptions field id can break mixed-version compatibility: any serialized payload that previously set field 186 for enable_aggregate_function_null_v2 will now be interpreted as enable_streaming_agg_hash_join_force_passthrough. If this struct crosses FE/BE boundaries across versions, consider keeping the existing id for the already-released option (and renumbering the newer/conflicting one), or otherwise document/enforce an upgrade constraint to avoid misinterpretation.

Copilot uses AI. Check for mistakes.

195: optional bool enable_left_semi_direct_return_opt;

200: optional bool enable_adjust_conjunct_order_by_cost;
Expand Down
Loading